search

nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
42 stars 22 forks source link

Add `pkg_test.go` files for every package #357

Closed thunderboltsid closed 10 months ago

thunderboltsid commented 10 months ago

Unless a _test.go file is present in a package, go toolchain will not consider that package for the purposes of coverage metrics. This is a regression and will be fixed in go1.22 but until then we need these files in each package to keep the coverage report honest.

There is an expected drop in code coverage with this PR. However the newer numbers will be a lot more accurate going forward.

deepakm-ntnx commented 10 months ago

/ok-to-test

thunderboltsid commented 10 months ago

/test e2e-ncn-1-calico-k8s-v.1.27-api-upgrade

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1f8716d) 13.62% compared to head (78e21da) 11.28%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #357 +/- ## ========================================== - Coverage 13.62% 11.28% -2.35% ========================================== Files 4 19 +15 Lines 1013 2021 +1008 ========================================== + Hits 138 228 +90 - Misses 875 1793 +918 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nutanix-cn-prow-bot[bot] commented 10 months ago

@adiantum: dog image

In response to [this](https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/pull/357#pullrequestreview-1813201848): >/lgtm >/approve >/woof Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nutanix-cn-prow-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, thunderboltsid, yannickstruyf3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/blob/main/OWNERS)~~ [adiantum,thunderboltsid,yannickstruyf3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment