nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
42 stars 22 forks source link

CertSAN added as a patch json in clusterclass patches #372

Open deepakm-ntnx opened 10 months ago

deepakm-ntnx commented 10 months ago

What this PR does / why we need it: Makes certSAN for apiServer configurable as variable in cluster with topology

certSANs[]string | certSANs sets extra Subject Alternative Names (SANs) for the API Server signing certificate.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

How Has This Been Tested?:

make test-e2e-calico LABEL_FILTERS=quickstart
When following the Cluster API quick-start with ClusterClass Should create a workload cluster [quickstart2, capx-feature-test]
/Users/deepak.muley/go/src/github.com/kubernetes-sigs/cluster-api/test/e2e/quick_start.go:78
  STEP: Creating a namespace for hosting the "quick-start" test spec @ 01/25/24 15:47:37.402
  INFO: Creating namespace quick-start-1v7ula
  INFO: Creating event watcher for namespace "quick-start-1v7ula"
  STEP: Creating a workload cluster @ 01/25/24 15:47:37.43
  INFO: Creating the workload cluster with name "quick-start-kt0qgz" using the "topology" template (Kubernetes v1.27.9, 1 control-plane machines, 1 worker machines)
  INFO: Getting the cluster template yaml
  INFO: clusterctl config cluster quick-start-kt0qgz --infrastructure (default) --kubernetes-version v1.27.9 --control-plane-machine-count 1 --worker-machine-count 1 --flavor topology
  INFO: Applying the cluster template yaml to the cluster
configmap/quick-start-kt0qgz-pc-trusted-ca-bundle created
configmap/nutanix-ccm created
secret/quick-start-kt0qgz created
secret/nutanix-ccm-secret created
clusterresourceset.addons.cluster.x-k8s.io/nutanix-ccm-crs created
kubeadmconfigtemplate.bootstrap.cluster.x-k8s.io/quick-start-kt0qgz-kcfg-0 created
clusterclass.cluster.x-k8s.io/e2e created
kubeadmcontrolplanetemplate.controlplane.cluster.x-k8s.io/e2e-kcpt created
nutanixclustertemplate.infrastructure.cluster.x-k8s.io/e2e-nct created
nutanixmachinetemplate.infrastructure.cluster.x-k8s.io/e2e-cp-nmt created
nutanixmachinetemplate.infrastructure.cluster.x-k8s.io/e2e-md-nmt created
configmap/cni-quick-start-kt0qgz-crs-cni created
clusterresourceset.addons.cluster.x-k8s.io/quick-start-kt0qgz-crs-cni created
cluster.cluster.x-k8s.io/quick-start-kt0qgz created

  INFO: Waiting for the cluster infrastructure to be provisioned
  STEP: Waiting for cluster to enter the provisioned phase @ 01/25/24 15:47:41.458
  INFO: Waiting for control plane to be initialized
  INFO: Waiting for the first control plane machine managed by quick-start-1v7ula/quick-start-kt0qgz-fw44r to be provisioned
  STEP: Waiting for one control plane node to exist @ 01/25/24 15:47:51.539
  INFO: Waiting for control plane to be ready
  INFO: Waiting for control plane quick-start-1v7ula/quick-start-kt0qgz-fw44r to be ready (implies underlying nodes to be ready as well)
  STEP: Waiting for the control plane to be ready @ 01/25/24 15:48:51.669
  STEP: Checking all the control plane machines are in the expected failure domains @ 01/25/24 15:49:01.685
  INFO: Waiting for the machine deployments to be provisioned
  STEP: Waiting for the workload nodes to exist @ 01/25/24 15:49:01.717
  STEP: Checking all the machines controlled by quick-start-kt0qgz-md-0-lfxr9 are in the "" failure domain @ 01/25/24 15:49:21.757
  INFO: Waiting for the machine pools to be provisioned
  STEP: PASSED! @ 01/25/24 15:49:21.845
  STEP: Dumping logs from the "quick-start-kt0qgz" workload cluster @ 01/25/24 15:49:21.845
Failed to get logs for Machine quick-start-kt0qgz-fw44r-l77sj, Cluster quick-start-1v7ula/quick-start-kt0qgz: error creating container exec: Error response from daemon: No such container: quick-start-kt0qgz-fw44r-l77sj
Failed to get logs for Machine quick-start-kt0qgz-md-0-lfxr9-pv6q9-8r88f, Cluster quick-start-1v7ula/quick-start-kt0qgz: error creating container exec: Error response from daemon: No such container: quick-start-kt0qgz-md-0-lfxr9-pv6q9-8r88f
  STEP: Dumping all the Cluster API resources in the "quick-start-1v7ula" namespace @ 01/25/24 15:49:22.008
  STEP: Deleting cluster quick-start-1v7ula/quick-start-kt0qgz @ 01/25/24 15:49:22.243
  STEP: Deleting cluster quick-start-kt0qgz @ 01/25/24 15:49:22.272
  INFO: Waiting for the Cluster quick-start-1v7ula/quick-start-kt0qgz to be deleted
  STEP: Waiting for cluster quick-start-kt0qgz to be deleted @ 01/25/24 15:49:22.285
  STEP: Deleting namespace used for hosting the "quick-start" test spec @ 01/25/24 15:49:52.311
  INFO: Deleting namespace quick-start-1v7ula
• [134.955 seconds]

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output

Special notes for your reviewer: TODO:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.24%. Comparing base (c075eb4) to head (26cba45). Report is 58 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #372 +/- ## ======================================= Coverage 15.24% 15.24% ======================================= Files 18 18 Lines 1207 1207 ======================================= Hits 184 184 Misses 1023 1023 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thunderboltsid commented 10 months ago

/retest