nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
42 stars 22 forks source link

Update Linter usage in project #373

Closed thunderboltsid closed 10 months ago

thunderboltsid commented 10 months ago

Linting targets weren't included in build processes making way for unlinted go and yaml files in the codebase. This PR add the linters in place using golangci-lint and yamllint and fixes the linting errors highlighted.

github-actions[bot] commented 10 months ago

:white_check_mark: None of your dependencies violate policy!

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cca8316) 15.21% compared to head (c9ff756) 15.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #373 +/- ## ========================================== + Coverage 15.21% 15.24% +0.02% ========================================== Files 18 18 Lines 1209 1207 -2 ========================================== Hits 184 184 + Misses 1025 1023 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thunderboltsid commented 10 months ago

/retest

nutanix-cn-prow-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/blob/main/OWNERS)~~ [adiantum,thunderboltsid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thunderboltsid commented 10 months ago

/hold

thunderboltsid commented 10 months ago

/test e2e-capx-controller-upgrade

thunderboltsid commented 10 months ago

/hold cancel