nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV

https://opendocs.nutanix.com/capx/latest/getting_started/

Apache License 2.0

42 stars 22 forks source link

Cherry-pick PR #369 to release-v1.3 #375

Closed thunderboltsid closed 9 months ago

thunderboltsid commented 9 months ago

Cherry-Pick Details

Original PR Title: remove CPU/Memory resources settings
Original PR URL: https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/pull/369
Commit SHA: 9a6aa49083ab5d959f3fa2ebd2707b3845d4f0a4
Cherry-Pick Reason: We need to make a v1.3.1 release with the limits removed.

thunderboltsid commented 9 months ago

/hold

thunderboltsid commented 9 months ago

/test e2e-capx-controller-upgrade

thunderboltsid commented 9 months ago

/retest

thunderboltsid commented 9 months ago

/test e2e-capx-conformance

nutanix-cn-prow-bot[bot] commented 9 months ago

@thunderboltsid: The specified target(s) for /test were not found. The following commands are available to trigger optional jobs:

/test e2e-capx-controller-upgrade

Use /test all to run all jobs.

In response to [this](https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/pull/375#issuecomment-1932182952): >/test e2e-capx-conformance Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

thunderboltsid commented 9 months ago

/test e2e-capx-conformance

thunderboltsid commented 9 months ago

/test e2e-k8s-upgrade

thunderboltsid commented 9 months ago

/test e2e-k8s-upgrade

thunderboltsid commented 9 months ago

/unhold

thunderboltsid commented 9 months ago

/hold

thunderboltsid commented 9 months ago

/unhold

github-actions[bot] commented 9 months ago

:white_check_mark: None of your dependencies violate policy!

thunderboltsid commented 9 months ago

Needed to merge #380 first to ensure tests here can run as expected.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3954b3d) 12.53% compared to head (ef660d8) 12.53%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## release-v1.3 #375 +/- ## ============================================= Coverage 12.53% 12.53% ============================================= Files 20 20 Lines 2003 2003 ============================================= Hits 251 251 Misses 1752 1752 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thunderboltsid commented 9 months ago

/retest

thunderboltsid commented 9 months ago

/hold

thunderboltsid commented 9 months ago

/unhold

yannickstruyf3 commented 9 months ago

/approve

nutanix-cn-prow-bot[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thunderboltsid, tuxtof, yannickstruyf3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/blob/release-v1.3/OWNERS)~~ [thunderboltsid,tuxtof,yannickstruyf3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment