nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
42 stars 22 forks source link

Cherry-pick PR #379 to release-v1.3 #380

Closed thunderboltsid closed 9 months ago

thunderboltsid commented 9 months ago

Cherry-Pick Details

github-actions[bot] commented 9 months ago

:white_check_mark: None of your dependencies violate policy!

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (120a46d) 12.53% compared to head (4acdfc6) 12.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-v1.3 #380 +/- ## ============================================= Coverage 12.53% 12.53% ============================================= Files 20 20 Lines 2003 2003 ============================================= Hits 251 251 Misses 1752 1752 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yannickstruyf3 commented 9 months ago

/approve

nutanix-cn-prow-bot[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thunderboltsid, tuxtof, yannickstruyf3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/blob/release-v1.3/OWNERS)~~ [thunderboltsid,tuxtof,yannickstruyf3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yannickstruyf3 commented 9 months ago

/lgtm