search

nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
41 stars 22 forks source link

Remove stale E2E test #413

Closed thunderboltsid closed 7 months ago

thunderboltsid commented 7 months ago

With https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/pull/400 we made prismCentral a mandatory field in NutanixCluster. In the PR we did not remove the E2E test that was covering the older behavior of successfully creating a NutanixCluster without credentials using the default credentials from the CAPX controller. As a result, the test is now failing on both periodic jobs since and presubmits on new PRs with the following error:

NutanixCluster.infrastructure.cluster.x-k8s.io \"cluster-ntnx-client-qwqlsf\" is invalid: spec.prismCentral: Required value

Not quite sure why this failure was not caught and addressed in #400. This PR removes the test that tests the stale example that is no longer supported.

thunderboltsid commented 7 months ago

/retest

nutanix-cn-prow-bot[bot] commented 7 months ago

@thunderboltsid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-capx-clusterclass 8e95413b3a8a10dfbbade100654ea7e2072cc159 link false /test e2e-capx-clusterclass
ci/prow/e2e-nutanix-features 8e95413b3a8a10dfbbade100654ea7e2072cc159 link false /test e2e-nutanix-features

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
thunderboltsid commented 7 months ago

Closing this PR in favor of https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/pull/414 as reverting the E2E test alone doesn't fix the broken CI as the change also broke clusterclass support. For now, we'll just revert changes in https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/pull/400