nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
41 stars 22 forks source link

Cherry-pick PR #416 to release-v1.3 #432

Closed thunderboltsid closed 6 months ago

thunderboltsid commented 6 months ago

Cherry-Pick Details

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 16.58%. Comparing base (814f505) to head (a4bb472).

Files Patch % Lines
main.go 64.28% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-v1.3 #432 +/- ## ================================================ + Coverage 15.49% 16.58% +1.08% ================================================ Files 21 21 Lines 2098 2129 +31 ================================================ + Hits 325 353 +28 - Misses 1773 1776 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nutanix-cn-prow-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/blob/release-v1.3/OWNERS)~~ [adiantum,thunderboltsid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
github-actions[bot] commented 6 months ago

:white_check_mark: None of your dependencies violate policy!

thunderboltsid commented 6 months ago

/retest