search

nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
41 stars 22 forks source link

Set OwnerRef on TrustBundle configmaps and add selfhosted E2E test #438

Closed thunderboltsid closed 5 months ago

thunderboltsid commented 6 months ago

This PR adds a E2E test for clusterctl move and also adds a method to reconcile trust bundle refs in NutanixmachineReconciler to set ownerReference on trust bundle configmaps so those configmaps get moved when clusterctl move operation happens.

thunderboltsid commented 6 months ago

/retest

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 29.65%. Comparing base (0fdeb83) to head (0100072).

Files Patch % Lines
controllers/nutanixcluster_controller.go 87.50% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #438 +/- ## ========================================== + Coverage 28.37% 29.65% +1.28% ========================================== Files 14 14 Lines 1304 1332 +28 ========================================== + Hits 370 395 +25 - Misses 934 937 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thunderboltsid commented 6 months ago

/retest

thunderboltsid commented 6 months ago

/retest

thunderboltsid commented 6 months ago

/retest

thunderboltsid commented 6 months ago

/retest

nutanix-cn-prow-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, deepakm-ntnx, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/blob/main/OWNERS)~~ [adiantum,deepakm-ntnx,thunderboltsid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment