nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
41 stars 22 forks source link

Cherry-pick PR #436 to release-v1.3 #441

Closed thunderboltsid closed 5 months ago

thunderboltsid commented 5 months ago

Cherry-Pick Details

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 18.50%. Comparing base (452ad29) to head (4effc2b).

Files Patch % Lines
controllers/nutanixmachine_controller.go 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-v1.3 #441 +/- ## ================================================ + Coverage 17.84% 18.50% +0.65% ================================================ Files 22 22 Lines 2146 2156 +10 ================================================ + Hits 383 399 +16 + Misses 1763 1757 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nutanix-cn-prow-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, deepakm-ntnx, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/blob/release-v1.3/OWNERS)~~ [adiantum,deepakm-ntnx,thunderboltsid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thunderboltsid commented 5 months ago

/retest

github-actions[bot] commented 5 months ago

:white_check_mark: None of your dependencies violate policy!

thunderboltsid commented 5 months ago

/test e2e-k8s-upgrade