search

nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
41 stars 22 forks source link

feat(controller)!: Remove default category creation and deletion #471

Open thunderboltsid opened 3 months ago

thunderboltsid commented 3 months ago

CAPX should not be concerned with creating and deleting categories. CAPX consumers should create any category they deem necessary and add it via "additionalCategories" field on NutanixMachine CR.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.45%. Comparing base (ce22e6b) to head (9eb0a9f).

Files Patch % Lines
controllers/nutanixmachine_controller.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #471 +/- ## ========================================== + Coverage 31.14% 34.45% +3.31% ========================================== Files 14 14 Lines 1477 1335 -142 ========================================== Hits 460 460 + Misses 1017 875 -142 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.