nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
40 stars 23 forks source link

fix(controller): Optimize logic for detach VG from VM for cases with large number of VGs #477

Closed thunderboltsid closed 2 months ago

thunderboltsid commented 2 months ago

We optimize the logic and add some guardrails

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 33.00%. Comparing base (5d63d09) to head (69f7b5b). Report is 1 commits behind head on main.

Files Patch % Lines
controllers/nutanixmachine_controller.go 12.50% 7 Missing :warning:
controllers/helpers.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #477 +/- ## ========================================== + Coverage 32.56% 33.00% +0.43% ========================================== Files 17 17 Lines 1833 1809 -24 ========================================== Hits 597 597 + Misses 1216 1192 -24 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.