Closed thunderboltsid closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 33.14%. Comparing base (
78f61d1
) to head (cfbda29
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing this PR as URL encoding doesn't take care of all escaping. e.g. /subnets/list is a POST endpoint and the filter is passed as a json object where the |
has to be escaped as \\|
. We have decided to make a tradeoff in favor correctness in exchange for performance and do all filtering client-side. We might revisit a more exhaustive FIQL filtering in the future but for now switch to client side filters See #485
Not encoding the name can cause errors when non-standard characters are present in the name.
How has this been tested? Unter testing
vlan173|ncn|dev|sandbox
Current status: with these changes we are still seeing failed machines with: