search

nutanix-cloud-native / cluster-api-runtime-extensions-nutanix

https://nutanix-cloud-native.github.io/cluster-api-runtime-extensions-nutanix/
Apache License 2.0
7 stars 4 forks source link

build: fix amd64 binary used in arm64 image #823

Closed dkoshkin closed 1 month ago

dkoshkin commented 1 month ago

What problem does this PR solve?: The published CAREN images have an amd64 binary in the arm64 image. This fixes that by using ko directly instead of using GoReleaser's kos. Both the dev and prod ko builds are moved to before.hooks.

Which issue(s) this PR fixes: Fixes #

How Has This Been Tested?:

Published to a private repo and verified that the binary inside the arm64 image is an arm64 binary.

Special notes for your reviewer:

dkoshkin commented 1 month ago

Alternative approach in #824 which I think is a bit cleaner.

Thanks, I like your PR more, closing this one.