Closed jimmidyson closed 1 month ago
The error on Nutanix is to do with reserving the IPs for the CP endpoint:
failed to wait for task completion: failed to wait for task ZXJnb24=:2c4527f5-30b4-4562-98d7-c99345cb9410 to complete: context deadline exceeded
I think we may have a leak but this is blocking PR merges so we need to fix this ASAP.
Previous builds were overriding the
GOOS
andGOARCH
enviroment variables, which is fine to do when usingko
directly, but appears to be broken when building via ko usinggoreleaser
.This commit ensures that
GOOS
andGOARCH
are always unset when running builds by undefining them viamake
undefine
. Theoverride
keyword ensures that the env vars are always undefined regardless of the source (e.g. enviroment, make variables, etc) to ensure a clean build environment.Instead of using
GOARCH
env var for building for the local build architecure, this commit usesgoreleaser
's{{ .Runtime.Goarch }}
variable available via templating which contains the architecture of the build machine.This commit also removes the
ldflags
config from theko
configuration ingoreleaser
config as this is automatically inherited from thebuild
config referenced in theko
config.