Closed dkoshkin closed 3 weeks ago
@dkoshkin So with this error the deployment shows as ready but it's not working properly so we should check the status configmap too?
@dkoshkin So with this error the deployment shows as ready but it's not working properly so we should check the status configmap too?
Yep! Attempt on the check here https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pull/867/commits/f203f8acf2cef15edefe5fcb098e4f81b3b954ea.
The new ConfigMap test failed as expected without this fix https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pull/868#issuecomment-2292675203
What problem does this PR solve?: Fixes an issue with CRS genertated CA Deployment not working because of extra quotes.
The extra quotes are only an issue in
--node-group-auto-discovery=
, but the same script replaces all occurrences. It should be safe to drop the single quotes everywhere though because the name and namespace will be strings and won't be interpreted as numbers by yaml.Which issue(s) this PR fixes: Fixes #
How Has This Been Tested?:
Special notes for your reviewer:
~I think we can improve the e2e tests by checking that all Deployments are Ready on the self-managed clusters, but I did not do that as part of this PR.~ The tests already do that https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/blob/f632224257cb159b04abc2c6c6eb6874c503bb1c/test/e2e/clusterautoscaler_helpers.go#L115
Instead we can also wait for the status ConfigMap to be
Running
This is what the data will contain for a working Deployment:And for non working: