search

nutanix-cloud-native / packer-plugin-nutanix

Packer Builder for Nutanix AHV
https://developer.hashicorp.com/packer/integrations/nutanix-cloud-native/nutanix
Apache License 2.0
35 stars 19 forks source link

remove FIQL filter to avoid bug #204

Closed tuxtof closed 1 month ago

tuxtof commented 1 month ago

What this PR does / why we need it:

FIQL filtering has been deprecated by the APIs for some time now. We should avoid using it altogether. We were doing a 2-pass filtering earlier (FIQL + Client Side) and with this change we remove the first pass filtering and all filtering will be done by what was earlier the second pass client side filter.

How Has This Been Tested?:

manual test with different subnet name

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

- remove server side filtering
thunderboltsid commented 1 month ago

LGTM for most part; while at it let's use strings.EqualFold for string equality check similar to https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/pull/485/files#diff-7d084ba6e9e15005850c1b44d72d457cef09f12badee416beda37f957a242364R211