search

nutanix / calm-dsl

Keep Calm and DSL On!
https://nutanix.github.io/calm-dsl/
Apache License 2.0
33 stars 51 forks source link

[Bug] --with_endpoints option is ignored in publish runbooks #255

Closed nutken closed 6 months ago

nutken commented 1 year ago

Description Specifying the --with_endpoints option when publishing a runbook does not retain the endpoints as expected

Branch/Container release/3.5.2, master

To Reproduce calm publish runbook --name "My Runbook" --version 1.2.3 --project myproj --with_secrets --with_endpoints --publish_to_marketplace "my-runbook"

Expected behavior Marketplace manager will show the runbook 'Published with endpoints' checkbox checked.

Findings/Troubleshooting Done publish_runbook in marketplace_runbook_commands.py accepts the with_endpoints parameter but doesn't pass it on to publish_runbook_as_new_marketplace_item or publish_runbook_as_new_marketplace_item, so its value defaults to False. A similar omission exists in marketplace.py, when publish_runbook_to_marketplace_manager() is called.

dwivediprab commented 6 months ago

Issue is fixed in DSL v3.7.2.2 release, Hence closing it.