search

nutanix / helm

Nutanix Helm Charts repository
https://nutanix.github.io/helm/
MIT License
17 stars 30 forks source link

Ability to specify resources request and limits in Deployments and DeamonSet #138

Open murand78 opened 5 months ago

murand78 commented 5 months ago

Currently

https://github.com/nutanix/helm/blob/master/charts/nutanix-csi-storage/templates/ntnx-csi-node-ds.yaml https://github.com/nutanix/helm/blob/master/charts/nutanix-csi-storage/templates/ntnx-csi-controller-deployment.yaml

have a QoS Guaranteed with fixed resource request. In small dev clusters I notice that 0.5 CPU and 800MB of RAM are reserved, while only 0.0005 CPU and 200MB are used.

Can be possible to parametrize resources based on helm values?

Eg, replacing in templates:

      {{- with .Values.controller.resources }}
      resources:
        {{- toYaml . | nindent 12 }}
      {{- end }}

instead of :

      resources:
        requests:
          cpu: 100m
          memory: 200Mi
tuxtof commented 5 months ago

we plan to integrate it in next CSI 3.0 release did you expect to have it only for main controller or also for sidecards ?

murand78 commented 5 months ago

Could be nice to have all resources configurable.

tuxtof commented 5 months ago

ok noted