nutanix / helm

Nutanix Helm Charts repository
https://nutanix.github.io/helm/
MIT License
18 stars 31 forks source link

Fix granularity for nodeSelector and tolerations #34

Closed danielvinitski closed 3 years ago

danielvinitski commented 3 years ago

In this PR i fixed the nodeSelector and tolerations so the user can apply different tolerations and nodeSelector for each deployment.

csi-provisioner-ntnx-plugin StatefulSet: nodeSelector - if the value nodeSelectorCsiProvisionerNtnxPlugin not set it will take the default from nodeSelector. tolerations - if the value tolerationsCsiProvisionerNtnxPlugin not set it will take the default from tolerations.

snapshot-controller StatefulSet: nodeSelector - if the value nodeSelectorSnapshotController not set it will take the default from nodeSelector. tolerations - if the value tolerationsSnapshotController not set it will take the default from tolerations.

csi-node-ntnx-plugin DaemonSet: nodeSelector - if the value nodeSelectorCsiNodeNtnxPlugin not set it will take the default from nodeSelector. tolerations - if the value tolerationsCsiNodeNtnxPlugin not set it will take the default from tolerations.

tuxtof commented 3 years ago

Hello @danielvinitski , nice to meet you and thanks for this PR. I will merge this improvement quickly for sure it was on the todo list