nutanix / libvfio-user

framework for emulating devices in userspace
BSD 3-Clause "New" or "Revised" License
166 stars 51 forks source link

use CMake's build type instead of "dbg" #639

Closed tmakatos closed 2 years ago

tmakatos commented 2 years ago

We use "dbg" for debug build but expect "Release" for release builds: https://github.com/nutanix/libvfio-user/blob/314ed91fd991756bef2c87ecdf7feff4016c1d40/Makefile#L31

Let's be consistent and use CMake's values.

jlevon commented 2 years ago

will become irrelevant when we move to meson

tmakatos commented 2 years ago

superseded by #666