search

nutanix / libvfio-user

framework for emulating devices in userspace
BSD 3-Clause "New" or "Revised" License
166 stars 51 forks source link

drop usage of MD5_*() #667

Closed jlevon closed 2 years ago

jlevon commented 2 years ago

These functions from openssl are deprecated, and hence break builds with openssl 3.0, which now has a compiler warning for them. We only use them to check buffer contents; replace them with CRC code from DPDK instead, and entirely drop use of openssl.

Signed-off-by: John Levon john.levon@nutanix.com

swapnili commented 2 years ago

Instead of copying rte_hashcrc.h, why not simply use EVP*. There is also wrapper function EVP_Digest() which makes it way easier than using Init, Update and FInal.

jlevon commented 2 years ago

It seemed silly to have to have the openssl dependency just for some test code, and this way we don't need to worry about openssl breaking us again.