nutanix / libvfio-user

framework for emulating devices in userspace
BSD 3-Clause "New" or "Revised" License
166 stars 51 forks source link

build PR runs in release mode #669

Closed jlevon closed 2 years ago

jlevon commented 2 years ago

Instead of "plain", which doesn't specify any optimization, use "release", which both turns off -DDEBUG and enables -O3.

Signed-off-by: John Levon john.levon@nutanix.com

jlevon commented 2 years ago

cc @berrange

berrange commented 2 years ago

The change looks fine, though strangely it has exposed some valgrind traces in the python tests.

jlevon commented 2 years ago

Yep, there's a bug in CPython somehow related to calling into optimized libraries - I need to move our default back to unoptimized