search

nutanix / libvfio-user

framework for emulating devices in userspace
BSD 3-Clause "New" or "Revised" License
166 stars 51 forks source link

dma: Clean up _dma_mark_dirty #692

Closed raphael-nutanix closed 5 months ago

raphael-nutanix commented 2 years ago

Low priority - just the suggestion I had here: https://github.com/nutanix/libvfio-user/pull/677#issuecomment-1140871862

jlevon commented 2 years ago

@raphael-nutanix as I mentioned, this implementation won't work as is, you should be able to reproduce with "make pytest"

raphael-nutanix commented 2 years ago

Haven't debugged the timeout. I'm seeing it on my local with the prior commit checked out so not sure it's me.

jlevon commented 2 years ago

timeout isn't you, we have a long-standing race in client/server code.

tmakatos commented 1 year ago

Is this PR still relevant?

raphael-nutanix commented 1 year ago

It's as relevant as it ever was. I still think it's a nice cleanup and possibly comes with a perf boost but I'll leave it to you guys to decide.

jlevon commented 5 months ago

Closing this as there's nothing particularly wrong with the existing code, that we're aware of.