nutanix / libvfio-user

framework for emulating devices in userspace
BSD 3-Clause "New" or "Revised" License
162 stars 51 forks source link

fix err/req irq fd issue #731

Closed limiao-intel closed 1 year ago

limiao-intel commented 1 year ago

When handle_device_set_irqs set err irq/req irq, fd will be filled in vfu_ctx->irqs->efds[] rather than vfu_ctx->irqs->err_efd/vfu_ctx->irqs->req_efd. So, err/req irq fd will be mistakenly used as msi/x irq fd, which will cause program stuck.

jlevon commented 1 year ago

@limiao-intel hey, are you planning on updating this for the code review comments above? Thanks.

limiao-intel commented 1 year ago

I will update patch based on code review comments above later. Thanks!

limiao-intel commented 1 year ago

@jlevon @tmakatos Hi, I update the patch according to your comments. Thanks!