Closed w-henderson closed 1 year ago
Hi William, thanks! Looks like a great start. Let's split things up from your branch into individual PRs - this will let us review each logical change on its own. Some context here: https://movementarian.org/blog/posts/github-prs/
As for the first change here, this looks good, but could you add some context to the commit message? In particular:
@w-henderson Is this PR up for review or WIP I see that the build is failing? Are you going to split this into small logical PRs?
@swapnili This PR has since been split into the smaller #745 #746 #747 #754 which are at various different stages of development, I'll close this one since it's no longer relevant.
This PR will (when done):
Closes #654