search

nutanix / libvfio-user

framework for emulating devices in userspace
BSD 3-Clause "New" or "Revised" License
168 stars 51 forks source link

Add another lspci test output variant #761

Closed gierens closed 1 year ago

gierens commented 1 year ago

On my Arch-based systems (Linux 6.1.44-lts) with pciutils 3.10.0 the lspci output is a little different causing the lspci test to fail. Do/Did you test it on a different version of pciutils, or is lspci just that on different distros?

Anyway I added the output I'm getting as and altered the test script accordingly.

gierens commented 1 year ago

ah, just saw the workflow, yeah those distros all have other versions of pciutils apparently.

swapnili commented 1 year ago

Currently we do not test on Arch platform in the github workflow. But feel free to add it and see if all test pass maybe other tests also needs some fixing. Thanks

jlevon commented 1 year ago

@gierens thanks. Would you mind altering your commit message to add a Signed-off-by, and also describe in more detail why you need the change (Arch version and lspci version please).

gierens commented 1 year ago

So I added the signed-off and a few more details regarding the versions to the commit message ... sorry about forgetting the signed-off, just read that in the README must have overlooked it the first time. As to why I need this, well simply so the tests don't fail here. And since it merely adds a variant and doesn't affect anything for the distros you officially support or test against I thought it couldn't hurt to at least mention this. At some point other distros might bump their pciutils versions as well.

jlevon commented 1 year ago

To be clear, I wasn't asking why you need this, but to add that info to the commit message, which you've done now, thanks.

jlevon commented 1 year ago

@gierens if you like, we would also take a PR to add Arch to .github/workflows/pull_request.yml