nutanix / libvfio-user

framework for emulating devices in userspace
BSD 3-Clause "New" or "Revised" License
168 stars 51 forks source link

initial migration state not specified #779

Open tmakatos opened 1 year ago

tmakatos commented 1 year ago

VFIO uapi doesn't seem to specify the initial migration state of the device. Is it not required? Does the kernel code expect some speicfic state? In any case, we should check the code and clarify that in the vfio-user spec.

w-henderson commented 1 year ago

QEMU starts in RUNNING: https://elixir.bootlin.com/qemu/v8.0.4/source/hw/vfio/migration.c#L603

All I can find in the kernel is when the device resets, it gets set to RUNNING: https://elixir.bootlin.com/linux/v6.5.1/source/drivers/vfio/pci/mlx5/main.c#L1151

tmakatos commented 1 year ago

I can't find anything in the kernel either, maybe it doesn't matter, perhaps it's worth asking on lkml (make sure you CC the right people)?