lib/libvfio-user: Fix calloc-transposed-args reported by gcc >= 14

nutanix / libvfio-user

framework for emulating devices in userspace

BSD 3-Clause "New" or "Revised" License

168 stars 51 forks source link

lib/libvfio-user: Fix calloc-transposed-args reported by gcc >= 14 #802

Closed mikeBashStuff closed 3 months ago

mikeBashStuff commented 3 months ago

Fixes #801.

Signed-off-by: Michal Berger michal.berger@intel.com

jlevon commented 3 months ago

ugh, they broke centos-7, hold on :/

jlevon commented 3 months ago

Thanks for the fix @mikeBashStuff I have cherry-picked it to the branch spdk used for, well, SPDK. Would you like me to raise a gerrit there, or are you planning to do that?

mikeBashStuff commented 3 months ago

@jlevon I haven't looked into adjusting submodule on the SPDK's end yet, pushed this instead: https://review.spdk.io/gerrit/c/spdk/spdk/+/24558.

But if this pr is already merged I guess we could go with updating the submodule and dropping the above patch. So https://review.spdk.io/gerrit/c/spdk/spdk/+/24583.