search

nutanix / nutanix.ansible

Official Nutanix Ansible collections
GNU General Public License v3.0
67 stars 36 forks source link

[Imprv] add functionality <functionality_name> to module <module_name> #334

Open guntis-liepins opened 1 year ago

guntis-liepins commented 1 year ago

Describe the request Enable dry run mode with --check

Current behaviour Currently it seems to ignore this flag and just proceeds with operations like deleting vms regardless of value of this flag.

Expected behaviour With --check flag module must follow ansible check mode default behaviour: https://docs.ansible.com/archive/ansible/2.3/playbooks_checkmode.html i.e. show that it will create or delete objects instead of creating them.

Rationale: In production enviroments most admins want to check playbook first to make sure variables, host groups, etc. is set correctly and then proceed with operation. It is very dangerous to run multi machine complex playbooks without checking it prior production run.

bhati-pradeep commented 1 year ago

Moving it from 1.9.1 -> 1.9.3 as it would need test additions in all integration tests.