nutdotnet / WinNUT-Client

WinForms-based client for monitoring your Uninterruptible Power Supply (UPS) connected to a Network UPS Tools (NUT) server.
GNU General Public License v3.0
209 stars 19 forks source link

Log files still being saved in system root folder #61

Closed boblo44 closed 1 year ago

boblo44 commented 1 year ago

It seems that WinNUT log files are now being saved in a folder named :\Logs instead of at AppData\Roaming as originally happened. Am running WinNUT client v 2.2.8359.21169 on Win10Pro 22H2 Build 19045.2251. Current log is C:\Logs\WinNUT-Client-2022-11-23.log on my system, previous log was C:\WinNUT-Client\Logs\WinNUT-Client-2022-11-23.log.

gbakeman commented 1 year ago

That's been a persistent issue for sure. Could you please attach a log file, and I'll look into this further?

gbakeman commented 1 year ago

I can also reproduce this on my end, including in Debug build mode. I'll have some more core changes up soon.

gbakeman commented 1 year ago

When you get a chance, please download this debug build and run it in a temporary location, just to verify that it writes next to the executable. You may have to cleanup your C drive a little, sorry about that.

Once it looks good to you, I'll make a pre-release so it functions normally and writes to the appdata directory.

boblo44 commented 1 year ago

I’ve downloaded and unpacked the debug build but not sure how to get it to run. I’ve copied the contents of the .zip to a temporary location on my C: drive but double-clicking the WinNUT.exe has no effect even with Norton AV disabled. Please advise…

Bob

From: gbakeman @. @.> > Sent: 24 November 2022 01:27 To: nutdotnet/WinNUT-Client @. @.> > Cc: boblo44 @. @.> >; Author @. @.> > Subject: Re: [nutdotnet/WinNUT-Client] Log files still being saved in system root folder (Issue #61)

When you get a chance, please download this debug build https://github.com/nutdotnet/WinNUT-Client/suites/9478908215/artifacts/449134315 and run it in a temporary location, just to verify that it writes next to the executable. You may have to cleanup your C drive a little, sorry about that.

Once it looks good to you, I'll make a pre-release so it functions normally and writes to the appdata directory. A

— Reply to this email directly, https://github.com/nutdotnet/WinNUT-Client/issues/61#issuecomment-1325833915 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/A4LKU3WEOUQ3ENUFZ4HBBP3WJ275DANCNFSM6AAAAAASJHNW44 unsubscribe. You are receiving this because you authored the thread.Message ID: @. @.> >

gbakeman commented 1 year ago

That's a little odd... as far as where to run it, I was thinking you could extract it to a folder within your downloads folder, like User/Downloads/WinNUT-Client. Could you try that and see if it makes any difference?

boblo44 commented 1 year ago

No problem, I fixed it by unblocking all the files in the download – Windows security had blocked them all! You’ll be pleased to know that the log is now being written to the folder containing the WinNUT client: C:\WinNUT-Client-debugbuild-v2.2.8363.2520\WinNut-Client\Logs\WinNUT-Client-2022-11-24.log in my case.

Also, did you test the shutdown process? A while ago I tried running my UPS on battery until it died and didn’t get a smooth shutdown. I’ll play around with that some more before I flag it as an issue.

B

From: gbakeman @.> Sent: 24 November 2022 17:14 To: nutdotnet/WinNUT-Client @.> Cc: boblo44 @.>; Author @.> Subject: Re: [nutdotnet/WinNUT-Client] Log files still being saved in system root folder (Issue #61)

That's a little odd... as far as where to run it, I was thinking you could extract it to a folder within your downloads folder, like User/Downloads/WinNUT-Client. Could you try that and see if it makes any difference?

— Reply to this email directly, view it on GitHub https://github.com/nutdotnet/WinNUT-Client/issues/61#issuecomment-1326699778 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A4LKU3XHTVIPAYWMC7EB7E3WJ6O6HANCNFSM6AAAAAASJHNW44 . You are receiving this because you authored the thread.Message ID: @.***>

gbakeman commented 1 year ago

Thank you for confirming that!

Battery and power events have been tweaked several times so I think you should see better handling of that. Please let me know if you have any issues though.

I'll merge the changes and consider this issue closed, and a pre-release build should be out next week.