search

nutgaard / react-router-breadcrumbs

Breadcrumb component for react-router
Other
46 stars 11 forks source link

react-router 4.0.0 support #242

Open GreenAsJade opened 7 years ago

GreenAsJade commented 7 years ago

Just noting that react-router is on 4.0.0 now, but react-router-breadcrumbs specifies 3.x.x. only.

nutgaard commented 7 years ago

Thanks for adding this issue. 👍

react-router@4.x.x is a complete rewrite of the library, so I will have to take a look at it. At first glance it seems like a complete rewrite of this library is also necessary to be compliant with the new version.

GreenAsJade commented 7 years ago

Dang, eh?!

shawnmclean commented 7 years ago

Have you looked into this rewrite? I'm beginning to think breadcrumbs will be a complex component to build with this v4 update since routes are not explicit.

nutgaard commented 7 years ago

Hi @shawnmclean Things are a bit busy at work right now, so I haven't gotten around to it yet.

If you want though a PR is allways welcomed. :)

skipjack commented 7 years ago

Related discussion of v4 upgrade options over at svenanders/react-breadcrumbs#99 if anyone is interested. As you've all noted this will definitely be a tough problem to solve with the new rewrite.

hiradyazdan commented 4 years ago

This is like abandoned for quite some time! At least a deprecation notice will be useful in README.

https://github.com/nutgaard/react-router-breadcrumbs/pull/303