nutriot / bandcamp-api

Node.js library for the Bandcamp API
MIT License
11 stars 0 forks source link

Publish type declarations #11

Closed johngeorgewright closed 4 months ago

johngeorgewright commented 1 year ago

I just installed a fresh copy of @nutriot/bandcamp-api@0.4.1 but there are no type declarations. It would be great if you could add those to the published package.

idleberg commented 1 year ago

You could give the current main-branch a try, it has both type declarations and (incomplete) Zod schemas. Other than that you don't really risk anything, the rest of the code is about the same as the latest release. I'd appreciate some feedback.

The incomplete schemas and an outdated test needs to be fixed (actually, the test will probably run find, I need to update my test data).

idleberg commented 12 months ago

Update: I'm hoping to release a new version at the end of this week!

idleberg commented 11 months ago

The existing types should now be properly exposed using the 0.5 versions. However, the response types are work-in-progress, since there's no official documentation on them. I started creating Zod schemas for these, but I'm not sure the date from my own Bandcamp data is sufficient. In other words, I'm happy for PRs.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] commented 4 months ago

This issue was closed because it has been stalled for 30 days with no activity.