search

nutritionfactsorg / daily-dozen-android

Keep track of the foods that Dr. Greger recommends in his NYT's best-selling book, How Not to Die with this Android app
https://play.google.com/store/apps/details?id=org.nutritionfacts.dailydozen&hl=en
Other
274 stars 95 forks source link

Fix Issues #102 and #106 #108

Closed DJTai closed 6 years ago

slavick commented 6 years ago

@DJTai,

Thank you for your fix to issue #106, but I had to add it manually as the nestedScrollingEnabled xml property is only available on SDK level 21 and higher. This required the creation of a layout-v21 directory and duplicating the activity_food_info.xml layout file inside it (with your updates). If the property were to have been included in the base layout, it would have caused crashes for all users whose SDK level was less than 21.

As for your fix to issue #102, it's not simply a matter of increasing the number of checkboxes. As the app currently functions, all of the checkboxes are worth 1 point towards the daily total. This results in 24 total possible points for the day. Your change would have changed this to 26 and affected the calculations for all users. All users would have lost their gold stars for days in which they completed all of their servings. This change would have also made the app's checklist differ from that in How Not to Die. I think it's important that the checklist in the book matches the checklist in the app.

Thank you for raising this PR, I'm going to mark issue #106 fixed.

miyl commented 6 years ago

As far as I can see the book has one box for exercise? If you want the app to mirror the book 1:1 why is the issue open at all?

Maybe the issue could be made more explicit so it's clearer what you want. Regarding gold stars I guess the update must ensure that everyone with 1 checkmark (full) currently in exercise anywhere should be updated to 3 (full) in the new version?