nutritionfactsorg / daily-dozen-android

Keep track of the foods that Dr. Greger recommends in his NYT's best-selling book, How Not to Die with this Android app
https://play.google.com/store/apps/details?id=org.nutritionfacts.dailydozen&hl=en
Other
274 stars 95 forks source link

Half servings #112

Closed kmclark7 closed 3 years ago

kmclark7 commented 6 years ago

It would be great to be able to do half servings, perhaps a single vs double click, cycling through. The checkmark could be different colors.

senpl commented 6 years ago

Clickable progression bar would be even better. Especially in widget.

Peim8 commented 4 years ago

Hi, I have started to work on a solution with a seekBar, but with the half portions it has to be discussed how to store the values. Should they be still Integer? Or is a Float a better choice?

senpl commented 4 years ago

Should they be still Integer? Or is a Float a better choice?

Do the simplest things that could possibly work (https://www.artima.com/intv/simplest.html#part3).

kmclark7 commented 4 years ago

I imagine you could use integers and instead of counting servings, count half servings. Two half servings = 1 serving. That would probably be easiest.

On Tue, Aug 18, 2020 at 1:39 AM Michał Urbanek notifications@github.com wrote:

Should they be still Integer? Or is a Float a better choice?

Do the simplest things that could possibly work ( https://www.artima.com/intv/simplest.html#part3).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nutritionfactsorg/daily-dozen-android/issues/112#issuecomment-675286083, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4E7QWFA62PYRSRNCMIQCDSBIOZZANCNFSM4FS3BZWA .

-- Kristin Clark

senpl commented 4 years ago

Representing half with integers is just bad. And some users might want 1/3 portion. So float will be way to go.

kmclark7 commented 4 years ago

It depends on how accurate you want people to get. It is meant to be a really quick thing. So, you have to decide what you want. I think if you get into people entering 2.3, they may as well be using a more sophisticated app. I think this app is meant to be a quick tap.

On Tue, Aug 18, 2020, 11:36 AM Michał Urbanek notifications@github.com wrote:

Representing half with integers is just bad. And some users might want 1/3 portion. So float will be way to go.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nutritionfactsorg/daily-dozen-android/issues/112#issuecomment-675585840, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4E7QWMPHZ5N55BHGKOEA3SBKUXHANCNFSM4FS3BZWA .

senpl commented 4 years ago

With float you keep your options open. With int you limit usage to only one implementation. Also this could be in option if user want checkbox or seekbar/progress bar. It depends how good you want to make it. With float it could be extended to other implemenations.

Peim8 commented 4 years ago

Yes, okay, I will use float (and set the seekbar progress possibilities on half servings at first - then we can discuss later how to continue).

senpl commented 3 years ago

@PatriciaHeimfarth any progress on this ???

senpl commented 3 years ago

@christirichards it is good to write reason of closing issue. Because it not seems like done.