search

nutritionfactsorg / daily-dozen-android

Keep track of the foods that Dr. Greger recommends in his NYT's best-selling book, How Not to Die with this Android app
https://play.google.com/store/apps/details?id=org.nutritionfacts.dailydozen&hl=en
Other
274 stars 95 forks source link

Alphabetize food_info_types_exercise #132

Closed ingochris closed 4 years ago

ingochris commented 4 years ago

Great app! I noticed this string-array was a bit unorganized so I sorted it.

slavick commented 4 years ago

Hi @ingochris, thank you for the PR, unsorted lists drive me nuts too but unfortunately there is a method to the madness. There really should be two separate lists in the app for Exercise. The first should be for moderate-intensity exercises and the second for high-intensity exercises.

Besides the above, I cannot merge your PR because the ordering in strings.xml must match the orderings in the other translation files.

ingochris commented 4 years ago

Hi @slavick, thank you for the clarification! The separation of lists was not apparent in app.

Most of the exercises/sports can be performed at moderate or high intensities, so I'm unsure how accurate or effective it is to separate them in this manner.