search

nutritionfactsorg / daily-dozen-android

Keep track of the foods that Dr. Greger recommends in his NYT's best-selling book, How Not to Die with this Android app
https://play.google.com/store/apps/details?id=org.nutritionfacts.dailydozen&hl=en
Other
274 stars 95 forks source link

Develop #154

Closed lyspooner closed 3 years ago

lyspooner commented 4 years ago

I cleaned up strings.xml. Some grammar, some notes, some information.

lyspooner commented 4 years ago

This is my first pr. I tried following all available instructions. Feedback is welcome.

slavick commented 4 years ago

Thank you for the PR. I am not going to merge it in its current form as the text you want to change is the official language that NutritionFacts.org wants to use. Although the changes may be an improvement, those same improvements would also need to be applied to the other 9 languages.

Since you asked for feedback on your PR, here are a couple thoughts.

  1. The PR title of "Develop" is not informative as to the PR's purpose.
  2. All of your changes are contained in a single commit. This makes it impossible to cherry-pick the changes I like without accepting them all. For instance, I think the comment text fix is good as well as the added comments to food_quantities and tweak_amounts. The added comments to food_names doesn't provide any benefit as the corresponding food can be determined from the name of the string.

I will merge your PR if you revert the text changes to the official language.

senpl commented 3 years ago

@lyspooner any progress on this ???