search

nutritionfactsorg / daily-dozen-android

Keep track of the foods that Dr. Greger recommends in his NYT's best-selling book, How Not to Die with this Android app
https://play.google.com/store/apps/details?id=org.nutritionfacts.dailydozen&hl=en
Other
274 stars 95 forks source link

Add in the ability to toggle different units of measurements for categories #4

Closed christirichards closed 7 years ago

christirichards commented 8 years ago

The current categories list servings in cups/spoons. It has been highly requested that this information could be toggled to grams and (in the future) other units of measurement.

jpritikin commented 8 years ago

Cups/spoons would correspond to liters (a volume measure) not grams (a weight measure), but it would be nice to have both volume and weight.

MovGP0 commented 8 years ago

since the measurements doesn't need to be precise, the cups and spoons are useful for everyday use.

the litres and kilograms measurements are useful for beginners who want to get a feel of how much that really is. so having both is probably a good idea.

For the US based locale, there should also be measurements in anglo-american units.

For Reference see Wikipedia:Cooking weights and measures.

wywy22 commented 7 years ago

As user of metric system, it's hard to estimate the size of a cup or a glass. It would be good to have both info displayed or the a option for choosing between both.

MovGP0 commented 7 years ago

just figured that there is an additional problem with the spoon and cup sizes: in europe, we have cups and spoons of different sizes. the cups are 200 ml or 250 ml, and the spoons are much bigger.

wywy22 commented 7 years ago

Moreover, the sizing is in the strings.xml. Not the best for translation

MovGP0 commented 7 years ago

well, actually it is. however, the anglo american values should only be used in the "en-US" translation, while the default language, which is used in all the other countries, should use SI units.

vgstef commented 7 years ago

In Canada (en-CA and fr-CA), most people also use anglo american values.

rggjan commented 7 years ago

Also think it would be great to be able to switch!

slavick commented 7 years ago

I have been working on this, but I would love some help on actually converting the values to the metric system. Not being a user of the metric system, I'm not confident that I wouldn't make some glaring mistakes. Please let me know if you'd like to help.

Here's an early look at the UI for switching unit systems. Currently, it's a button that would switch to "metric" after you tap on it. Your most recent selection would be saved between app launches.

unit switching ui

rggjan commented 7 years ago

Cool, this would be perfect! I like the UI. Couldn't you just use chroot metric units from the book? For example: 20170619_202243

slavick commented 7 years ago

@rggjan If you have the time, can you send me screenshots of the serving sizes in your book? My book only has Imperial units. This would be great to put in the next update.

rggjan commented 7 years ago

@slavick of course! where should I send them to?

slavick commented 7 years ago

@rggjan I've sent you an email. Thank you very much!

slavick commented 7 years ago

This has been added in v13.