search

nutritionfactsorg / daily-dozen-android

Keep track of the foods that Dr. Greger recommends in his NYT's best-selling book, How Not to Die with this Android app
https://play.google.com/store/apps/details?id=org.nutritionfacts.dailydozen&hl=en
Other
274 stars 95 forks source link

Add support for deploying to F-Droid repository #81

Closed alibitek closed 6 years ago

alibitek commented 7 years ago

TODO:

Useful docs:

Fixes issues: #59

New releases are automatically built by F-Droid server because of the following metadata parameters:

Just need to tag new releases (as it is already the case) and F-Droid server will automatically build fdroidRelease build variant and sign it with its own app signing key and publish the update.

I've tested the update procedure using the metadata/build-fdroid.sh script and it works. I've updated the org.nutritionfacts.dailydozen.txt to use my master branch, because that's where it would look like if this pull request would get merged:

hacktoberfest

alibitek commented 7 years ago

@dimqua Managed to get a a Daily Dozen F-Droid build signed and tested on a device.

If you want to try it out download this apk (just replace .zip extension at the end with .apk, github wouldn't let me upload it otherwise) app-fdroid-release.zip

I've checked the APK with ClassyShark and no classes from Crashlytics are inside it.

alibitek commented 7 years ago

@slavick Can you please let me know if you support the inclusion of Daily Dozen in the F-Droid repository?

Information about F-Droid:

I will then submit a pull request against fdroiddata repository to include Daily Dozen in the apps fdroidserver builds.

alibitek commented 6 years ago

@slavick I've tested the app update mechanism on F-Droid using the metadata/build-fdroid.sh and metadata/org.nutritionfacts.dailydozen.txt files I've created and it works.

As a maintainer you don't have to do anything special to publish app updates to F-Droid repository. Just tag the release as usual and F-Droid figures it out automatically.

For the very first release I've updated the versionCode to 40 and versionName to "15" and set the Build config in metadata/org.nutritionfacts.dailydozen.txt to build the app with tag v15

When you think v15 branch is ready to be merged into master and tag the release with v15, I can send a pull request to fdroiddata repository, so that the metadata/org.nutritionfacts.dailydozen.txt will be included in the official F-Droid repository and the F-Droid Daily Dozen build can start.

alibitek commented 6 years ago

@slavick If you wish I can remove the metadata directory from the commit as it is only relevant for submitting a PR to F-Droid. I've updated the code several times and now it is in a state where it can be reviewed. Can you please have a look at it https://github.com/nutritionfactsorg/daily-dozen-android/pull/81/files and let me know if there are any changes to be done to get this PR merged?

jpritikin commented 6 years ago

@slavick Why would the maintainer hold this up? Doesn't make sense. Time to escalate to NF staff?

jpritikin commented 6 years ago

@christirichards Can you comment?

slavick commented 6 years ago

@alibitek Thank you for the PR. It is very well organized and well explained. I've merged in your changes and support your continued efforts in getting Daily Dozen included in F-Droid.

alibitek commented 6 years ago

@slavick

🌟 Awesome! 🎆

I've submitted a pull request to the F-Droid data repository: https://gitlab.com/fdroid/fdroiddata/merge_requests/2746

The only remaining impediment is that the v15 branch needs to get merged into master before the app can be added to the F-Droid repository.
As the app's metadata tells the build server to only create release builds from the tags defined in the master branch.

The v15 branch already has updated release information:

versionCode 40
versionName "15"

A log: git log --oneline --decorate --color master.. and diff betwen master and v15 branches yields the following changelog:

81ddf7c (HEAD -> v15, origin/v15) Use Get it on Google Play icon (#92)
3748262 Add support for deploying to F-Droid repository (#81)
7ed381b Add romanian translations (#79)
3d2369f Merge branch 'v15' into fix-issue-73
c402cd6 Rename "Spices" to "Herbs and Spices" (#86)
fc2a36d Fix incorrect dialog title for Generate Full Data button (#80)
fcfdd7d Fix issue #82 (#83)
3768a32 Rename "Nuts" to "Nuts and Seeds"
5014a10 (multiple-reminders/v15, github/v15) Removed some duplicated strings
012f920 Merge branch 'master' of https://github.com/rahul577/daily-dozen-android into rahul577-master
5a95597 Russian translation (#66)
96e60de Add and Update Chinese Translation
93b16fa Remove rice (#61)

Is Daily Dozen v15 ready to be 🚀 as an end of the year 🎁 ?

slavick commented 6 years ago

@alibitek Yes, there will be a release before the end of the year. I have some other changes for the v15 branch, so it won't be merged into master just yet. I'm pretty busy for the next week, so this will be happening after Christmas.

FHulot commented 6 years ago

This is great news. Thanks @alibitek and @slavick for all your work!