nutritionix / nutrition-label

Create a FDA-style nutrition label with any nutrition data source (even the Nutritionix API - http://www.nutritionix.com/api)
http://www.nutritionix.com/
MIT License
176 stars 66 forks source link

Remove Total Sugars %DV from Legacy and 2018 Label Versions #141

Closed majin22 closed 1 year ago

majin22 commented 1 year ago

link to the internal task https://syndigo.atlassian.net/browse/WELL-2210

Background:

There is no DV amount set for Total Sugars, yet on the legacy and 2018 labels, the labels are showing a %DV. The Canadian Version does contain a Total Sugars DV so perhaps these values on the legacy/2018 labels are using that calculation?

Regardless of any DV preferences selected on the Brand Display Preferences, the legacy and 2018 labels should never show a Total Sugars %DV.

Look at the Dunkin' On-site (Vue INM) account where even the Sugar DV preference is set to hidden, yet on the Vue INM, it is still showing the DV.

Task:

Remove Total Sugars %DV from the legacy and 2018 labels. Please ensure the cloud labels do not display this either.

majin22 commented 1 year ago

for the label, I can't remove the setting showDailySugars: false

I also changed dailyValueSugar: 100, //this should be 90 for the uk version to dailyValueSugar: 90, now that we set it so that the daily sugar value for the legacy and 2018 will always be hidden

thanks

majin22 commented 1 year ago

this change is being reverted

this is because the canada version of the label is just a copy of the label but with sugar daily value

so removing the feature will prevent the ability to recreate the canada label so it was requested to be put back

majin22 commented 1 year ago

@Yurko-Fedoriv I just want to let you know that a new version of the jquery label plugin has been published. Thanks.