Closed woutslakhorst closed 4 years ago
@stevenvegt Is it a hard requirement that approved certificate requests remain stored (for now). Since I changed logic so it deletes requests.
Merging #25 into master will increase coverage by
0.33%
. The diff coverage is84.97%
.
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...ain/kotlin/nl/nuts/discovery/api/CertificateApi.kt | 83.33% <100%> (+0.47%) |
7 <0> (ø) |
:arrow_down: |
src/main/kotlin/nl/nuts/discovery/NutsDiscovery.kt | 60% <100%> (ø) |
3 <0> (ø) |
:arrow_down: |
.../nuts/discovery/store/entity/CertificateRequest.kt | 100% <100%> (ø) |
5 <5> (?) |
|
...c/main/kotlin/nl/nuts/discovery/api/Certificate.kt | 100% <100%> (ø) |
6 <6> (?) |
|
...c/main/kotlin/nl/nuts/discovery/api/SignRequest.kt | 72.22% <100%> (ø) |
6 <1> (?) |
|
...iscovery/service/SimpleNetworkParametersService.kt | 89.47% <50%> (-4.28%) |
8 <0> (ø) |
|
...in/nl/nuts/discovery/store/CustomNodeRepository.kt | 62.5% <62.5%> (ø) |
3 <3> (?) |
|
...main/kotlin/nl/nuts/discovery/api/NetworkMapApi.kt | 69.23% <75%> (-0.22%) |
10 <3> (ø) |
|
...main/kotlin/nl/nuts/discovery/store/entity/Node.kt | 78.57% <78.57%> (ø) |
8 <8> (?) |
|
...kotlin/nl/nuts/discovery/store/entity/Signature.kt | 80% <80%> (ø) |
2 <2> (?) |
|
... and 12 more |
Having a persistent DB helps in setting up a local network/test network, production network. Hell.... all networks
Fixes #15
Signed-off-by: Wout Slakhorst wout.slakhorst@nedap.com