nuts-foundation / nuts-discovery

Discovery service by the Nuts foundation for bootstrapping the network
GNU General Public License v3.0
2 stars 1 forks source link

Fix wrong name constraints in signed nuts certificate #56

Closed woutslakhorst closed 4 years ago

woutslakhorst commented 4 years ago

Fixes #54

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit e9e826ef and detected 0 issues on this pull request.

View more on Code Climate.

codecov[bot] commented 4 years ago

Codecov Report

Merging #56 into master will increase coverage by 5.26%. The diff coverage is 82.87%.

Impacted Files Coverage Δ Complexity Δ
...in/nl/nuts/discovery/store/CustomNodeRepository.kt 62.50% <0.00%> (ø) 3.00 <0.00> (ø)
...s/discovery/service/AbstractCertificatesService.kt 42.85% <42.85%> (ø) 2.00 <2.00> (?)
.../kotlin/nl/nuts/discovery/api/ExceptionMappings.kt 66.66% <66.66%> (ø) 3.00 <3.00> (?)
...s/discovery/store/entity/NutsCertificateRequest.kt 80.00% <80.00%> (ø) 7.00 <7.00> (?)
...tlin/nl/nuts/discovery/store/entity/Certificate.kt 83.33% <80.95%> (-5.56%) 8.00 <4.00> (+4.00) :arrow_down:
...ts/discovery/service/CertificatesApiServiceImpl.kt 84.61% <84.61%> (+59.61%) 20.00 <20.00> (+19.00)
...tlin/nl/nuts/discovery/service/CertificateChain.kt 90.47% <90.47%> (ø) 4.00 <4.00> (?)
...ain/kotlin/nl/nuts/discovery/DiscoveryException.kt 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...nuts/discovery/service/CertificateAndKeyService.kt 90.27% <100.00%> (+4.94%) 12.00 <2.00> (ø)
.../nuts/discovery/service/NutsDiscoveryProperties.kt 100.00% <100.00%> (+25.00%) 13.00 <1.00> (+4.00)
... and 14 more