search

nuts-foundation / nuts-registry

Distributed registry for storing and querying healthcare care providers their vendors and technical endpoints.
GNU General Public License v3.0
0 stars 0 forks source link

update to latest crypto #174

Closed woutslakhorst closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #174 (cfea848) into master (d20a6c3) will increase coverage by 0.17%. The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/events/system.go 82.90% <ø> (ø)
pkg/events/domain/certificates.go 79.31% <100.00%> (+5.62%) :arrow_up:
woutslakhorst commented 3 years ago

Since verify now accepts a usage param, does this mean there is an extra error case to test for?

For signature checking, the hardcoded value of x509.ExtKeyUsageAny is used which will always succeed. A problem is that this repo implements the interface from nuts-crypto on the event handler. I'll check if that dependency can be removed.

woutslakhorst commented 3 years ago

@stevenvegt it's cleaner now and apparently there was some dead code as well