search

nuts4dotnet / TFSChatExtensions

Chrome Plugin that extends TFS/Visual Studio Team Chat
12 stars 3 forks source link

Master #8

Closed aschwab closed 8 years ago

aschwab commented 8 years ago
jcoutch commented 8 years ago

Thanks for the fixes! When I get a chance (hopefully in the next day or so), I'll test it out and push a new version to the Chrome store.

aschwab commented 8 years ago

The size of the notification's image is a bit magic but it should be sized to 144px

aschwab commented 8 years ago

Could you please merge the changes and update the Version in the Chrome-Store?

jcoutch commented 8 years ago

Sorry for the delay. Due to my day-to-day job, I've fallen behind on managing my various open-source projects. I'm going to try and set aside some time tonight to get a new version out. If not tonight, then definitely this weekend.

aschwab commented 8 years ago

I'm going to publish a forked version of TFSChatExtensions if that's ok for you

jcoutch commented 8 years ago

I am soooo sorry...the past couple months have been pretty crazy. Hold off on creating the fork...I'll check this out during lunch today (around 11:30-12:30 EST), and if everything looks good, will push a new version out immediately.

jcoutch commented 8 years ago

So, while I did merge this in and it may fix things for on-premise TFS, it breaks when using VSO. From what I can tell, each collection has it's own unique subdomain, uses DefaultCollection in url's, but the collectionName is the subdomain.

So if you have a project at testproject.visualstudio.com, URL's would look like this: https://testproject.visualstudio.com/DefaultCollection/_versionControl/changeset/1234?collectionName=testproject

I'm going to code up something real quick that will detect if the TLD is visualstudio.com, and switch on/off your logic.

jcoutch commented 8 years ago

Changes have been pushed, and I just dropped a new version of the extension in the store. I did notice what I think was a small bug w/ the changeset url's for on-premise instances...if you could test that and let me know if my fix worked, that'd be great. If not (and you have time to fix it), submit a pull request with the fix. I promise I'll be a bit more responsive from now on :-).