search

nutshell-platform / app

The react-native (expo) codebase of the Nutshell platform, with CI pipeline to Firebase.
https://nutshell.social/
0 stars 0 forks source link

Clarified release time #65

Closed bramgrolleman closed 4 years ago

bramgrolleman commented 4 years ago

Chose not to use Sunday midnight due to vagueness, instead clarified that release is on Monday at 00:00.

Closes #58

actuallymentor commented 4 years ago

Hmm I feel that people will get confused and think that is means midnight on monday (so monday 24:00). For that reason I think midnight works better...

~Did you do a rebase by any chance? I see a bunch of my commits in this PR. This is not an issue if you rebased after doing your commits, but could indicate an issue if you did not.~ I checked, it's fine.

actuallymentor commented 4 years ago

I added a commit with how I would do it, let me know if you agree.

bramgrolleman commented 4 years ago

Also fine. I think the midnight thing kind of makes things unnecessarily difficult and easy to make a mistake, tbh. Perhaps change it to Monday at 6:00 or something similar in the future?

bramgrolleman commented 4 years ago

And I think the reason for the many commits is that I based off of master and then merged into staging, which would be ahead, no?