nutterb / HydeNet

Hybrid Decision Networks in R
Other
23 stars 3 forks source link

Vignette images on CRAN #76

Closed jarrod-dalton closed 9 years ago

jarrod-dalton commented 9 years ago

There are some issues viewing the vignettes from the CRAN site. The header doesn't seem to have been processed, and the network plots aren't showing up.

nutterb commented 9 years ago

Grr...details.

This should be fixed and can be reviewed in the devel branch.

As a side note, do you object to me using the ArgumentCheck package to do all the argument checks rather than this whole routine:

  err.flag <- 0
  err.msg <- ""

  wrn.flag <- 0
  wrn.msg <- ""

  if(!all(c("y","x") %in% names(x))){
    err.flag <- err.flag + 1
    err.msg <- c(err.msg, paste0(err.flag,
                                 ": List object 'x' must contain character vectors ",
                                 "'y' and 'x'. See help('cpt')."))
  }

With ArgumentCheck it looks like this:

Check <- ArgumentCheck::newArgCheck(list = FALSE)

  ArgumentCheck::addError(!all(c("y","x") %in% names(x)),
                          paste0("List object 'x' must contain character vectors ",
                                 "'y' and 'x'. See help('cpt')."),
                          Check)
jarrod-dalton commented 9 years ago

No problem with that

On Jul 4, 2015, at 10:52 AM, Benjamin notifications@github.com wrote:

Grr...details.

This should be fixed and can be reviewed in the development branch.

As a side note, do you object to me using the ArgumentCheck package to do all the argument checks rather than this whole routine:

err.flag <- 0 err.msg <- ""

wrn.flag <- 0 wrn.msg <- ""

if(!all(c("y","x") %in% names(x))){ err.flag <- err.flag + 1 err.msg <- c(err.msg, paste0(err.flag, ": List object 'x' must contain character vectors ", "'y' and 'x'. See help('cpt').")) } With ArgumentCheck it looks like this:

Check <- ArgumentCheck::newArgCheck(list = FALSE)

ArgumentCheck::addError(!all(c("y","x") %in% names(x)), paste0("List object 'x' must contain character vectors ", "'y' and 'x'. See help('cpt')."), Check) — Reply to this email directly or view it on GitHub.