search

nutterb / pixiedust

Tables So Beautifully Fine-Tuned You Will Believe It's Magic.
178 stars 18 forks source link

Do not match on complete error message of checkmate in tests #112

Closed mllg closed 6 years ago

mllg commented 6 years ago

Hi there,

While preparing a new release of checkmate, I improved some error messages to provide additional information, e.g. the location of the first missing value in a vector. This unfortunately broke a unit test in your package. This PR should fix the test in question. Instead of matching on the complete sentence, the new pattern just matches the relevant part. I currently see no better way around this to make this more future-proof ...

It would be great if you could release a new version to CRAN in the next few weeks.

Best, Michel

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 92.442% when pulling 176d4426ab56cde9240b7ec64e50f475a3747d85 on mllg:master into 3a878b7f58205710275249c83e6e2ffe8c55610f on nutterb:master.

nutterb commented 6 years ago

Thank you. What's your timeline for your next CRAN release? I'll do my best to push an update before then.

mllg commented 6 years ago

My aim is to upload next Monday (May 7th). Let me know if this does not work for you.

nutterb commented 6 years ago

Sorry I'm so late. My updated submission was just accepted by CRAN.