search

nutterb / pixiedust

Tables So Beautifully Fine-Tuned You Will Believe It's Magic.
180 stars 15 forks source link

Remove Dplyr+Magrittr and Add Poorman #122

Open alex-gable opened 3 years ago

alex-gable commented 3 years ago

Love this package, but ran into some issues with internals, specifically those using dplyr.

Made updates to port the package off of dplyr + magrittr and onto poorman. The only issue I ran into blocking a "clean" port over was nathaneastwood/poorman#68

Most of these changes are whitespace changes which can be suppressed from the diff view.

Didn't know what to do with the Author/Maintainer/Version stuff so just threw in some fillers.

I realize this is "forward" or presumptuous and would be more than happy to walk through this in more detail!

Thanks for looking!

nutterb commented 3 years ago

I assure I'm not ignoring this. I'm quite interested in anything that can reduce my dependency footprint. I'm just not in a position to give this as thorough a review as it deserves right now.

You'll likely see an update to pixiedust go up to CRAN in the coming days. This is for a change requested by CRAN and must be handled in the next few days or the package will be archived.

alex-gable commented 3 years ago

No problem! Is there a branch I could rebase off of?