search

nutterb / pixiedust

Tables So Beautifully Fine-Tuned You Will Believe It's Magic.
180 stars 18 forks source link

Use trimws from backports #97

Closed shabbybanks closed 7 years ago

shabbybanks commented 7 years ago

To address https://github.com/rich-iannone/pointblank/issues/9 , I am replacing trimws with backports::trimws where needed. I put each edit in a separate commit to simplify cherry picking (but also because I cannot git clone on my work computer.) Your mileage may vary on whether you want to use backports::trimws in the README.md for example.

nutterb commented 7 years ago

I won't be committing this at this time, as backports does not export trimws.

shabbybanks commented 7 years ago

oops., my bad.

nutterb commented 7 years ago

No worries. It seemed like a good idea until Travis failed. If not for that, I wouldn't have noticed anything was wrong.

shabbybanks commented 7 years ago

It seems that trimws is not used in the code anywhere except in the documentation, vignette and README.rmd, where the fully quoted version backports::trimws would suffice. So removing the importFrom would suffice for a build, I think.