Closed shabbybanks closed 7 years ago
I am really surprised I don't use trimws
anywhere. Enough so that I almost done believe it even after checking myself! That's some good sleuthing.
I did some extra checks, just to make sure, and found that backports:::trimws
is a little weird, in that it only trims a single character of white space. Since I've already imported stringr
, let's just use str_trim
. Same effect, less overhead.
Also, as an FYI, if we were to use backports
, without it being in the source code, it would have needed to be in the Suggests
field. That would also get picked up in the CRAN checks.
Lastly, I've changed the R dependency to >= 3.1.2. This is equal to the dplyr
dependency and is as far back as I can get in my dependency chain.
Assuming the checks pass, I'll merge these in.
My apologies that I cannot test on travis, so this is hit and miss: rolling back R dependency to 3.0 via backports.