search

nutti / Screencast-Keys

Blender Add-on: Screencast Keys
GNU General Public License v3.0
1.27k stars 112 forks source link

add new visual options #54

Closed Kureii closed 3 years ago

Kureii commented 3 years ago

Add new feature add option of margin and round coner of background.

nutti commented 3 years ago

@Kureii

Thanks for the PR! It looks nice feature to me. I tried your patch in my environment. But the render result seems not fine. Background color and the rectangle size is invalid.

OS: Windows 10 Blender: Both 2.83 and 2.91

github_20210407

Could you check your patch in your environment?

nutti commented 3 years ago

@Kureii

Is there any update? If you stuck, I can help you.

Kureii commented 3 years ago

@nutti
Sorry only I don't have time, too much things to school

nutti commented 3 years ago

@Kureii

No, problem. If you need a help, feel free to tell me.

nutti commented 3 years ago

@Kureii

Is there any update about this PR? If you are not enough time to tackle this, I will try to do additional work.

Kureii commented 3 years ago

@nutti today I finishing my last projecto to the school and now I'll have a time for this

Kureii commented 3 years ago

I don't know, where I do mistake, I replace draw_box to draw_roundet_box, but it isint work in draw area mode...

nutti commented 3 years ago

@Kureii

Please double-check your patch while Background option is on. Your patch breaks the background and cursor color.

I will show you the expected behavior

github_20210713

nutti commented 3 years ago

@Kureii

BTW, does this patch work on your environment? I think that some changes break the layout.

If you provide me the specification of margin and background_round option, I will fix them.

nutti commented 3 years ago

I fixed your patch on my environment.

github_20210715

There are still UI break changes, so we need to fix other places too.

nutti commented 3 years ago

@Kureii

Is it possible to enable Allow edits by maintainers of this PR? If this option is enabled, I can commit my patch to your branch.

My patch also can be seen from kureii-patch branch.

Kureii commented 3 years ago

I had same problem and I didn't know how to repair it

nutti commented 3 years ago

@Kureii

I have already fixed your issue. So I want to merge my codes to your repository. Could you enable Allow edits from maintainers checkbox from right side of this PR?

Please also see this documents. https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Kureii commented 3 years ago

It's enable

nutti commented 3 years ago

@Kureii

Sorry for my failed operation.

I tried to fix the issue. At first, could you merge this PR? https://github.com/Kureii/Screencast-Keys/pull/1

nutti commented 3 years ago

@Kureii

Thanks for merging my PR. Now I can reopen this PR. I think the current version in master branch on your repository works fine (above bugs are fixed). Could you check this one on your environment?

Kureii commented 3 years ago

It's work good, I don't have any problem

nutti commented 3 years ago

@Kureii

Thanks. I will merge this PR after some small fix.

Kureii commented 3 years ago

I need more practise, this was my first try with coding blender add-on.

nutti commented 3 years ago

@Kureii

Thanks for nice suggestions and great works to this project. If you consider to contribute to this project more, feel free to open new PR. This project is contribution welcomed.

Kureii commented 3 years ago

thank you for your willingness and patience.